Fixed Indonesian Phone number Regex #863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Indonesian phone number validator previously allows any digit after +62.
This breaks our validation process where user can enter +621 and the validation returns as true thus costing us to send sms to an invalid number ie: +621
Fix
Fixed the indonesian phone regex to only accept +62 8nn || 08nn, where 8nn denotes the mobile phone provider in Indonesia. Then another 8-12 numbers as the phone number.
Based on the test, there are numbers which starts from 0. But referring to https://wikitravel.org/en/Wikitravel:Phone_numbers#Indonesia all mobile numbers will only starts with 8nn. I fixed the regex anyway to match all the test cases.