Add isIPRange validator #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriso
requested changes
Jun 12, 2018
src/lib/isIPRange.js
Outdated
|
|
||
| export default function isIPRange(str) { | ||
| assertString(str); | ||
| const [ip, subnet, err] = str.split('/'); |
There was a problem hiding this comment.
Do you mind avoiding this array destructuring syntax? It adds a fairly large helper function to validator.js and so validator.min.js
Example:
const parts = str.split('/', 3);
if (parts.length !== 2) {
return false;
}
const ip = parts[0];
const subnet = parts[0];
chriso
approved these changes
Jun 12, 2018
|
Thanks for the PR 😄 |
|
Awesome, thank you.
…On Tue, Jun 12, 2018 at 1:32 PM chriso ***@***.***> wrote:
Merged #842 <#842>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#842 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQOT1pBpLUj-3cpjAzHmFhi7SCJiYqeWks5t8CVigaJpZM4UfP-9>
.
|
|
Any timeline on getting this released? |
|
@gabegorelick |
|
@chriso Awesome! Thanks for the quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate IP Ranges for IPv4.