Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swedish locale and fix/add some unit tests #714

Merged
merged 5 commits into from
Sep 8, 2017
Merged

Add Swedish locale and fix/add some unit tests #714

merged 5 commits into from
Sep 8, 2017

Conversation

mika-s
Copy link
Contributor

@mika-s mika-s commented Sep 7, 2017

Added support for Swedish locale for isAlpha() and isAlphanumeric(). Fixes #712.

I also added some missing unit tests. I've not added unit tests for French as they are failing due to a reported bug in V8.

The Dutch regexp contains diacritics like accents and so on. Since most of them are in the regexp I added the remaining ones.

I was stupid enough to amend after pushing so there are two commits with the same message. But the readme will probably have a conflict anyway.

@linkinmedo
Copy link
Contributor

linkinmedo commented Sep 7, 2017

@mika-s lol I was just about to PR my fix, good thing I looked here first :P
btw add the following to your comment "fixes #712"

@chriso
Copy link
Collaborator

chriso commented Sep 8, 2017

Thanks!

@chriso chriso merged commit ea82b57 into validatorjs:master Sep 8, 2017
builtinnya added a commit to builtinnya/DefinitelyTyped that referenced this pull request Feb 20, 2018
Added isCurrency() options are:
  - allow_decimal
  - require_decimal
  - digits_after_decimal

Added locales are:
  - it-IT (validatorjs/validator.js#700)
  - sv-SE (validatorjs/validator.js#714)
  - ar-AE, ar-EG (validatorjs/validator.js#718)
  - ar-JO (validatorjs/validator.js#701)
  - sk-SK (validatorjs/validator.js#715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants