Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isISSN(). #593

Merged
merged 2 commits into from
Oct 14, 2016
Merged

Add isISSN(). #593

merged 2 commits into from
Oct 14, 2016

Conversation

hkwu
Copy link
Contributor

@hkwu hkwu commented Oct 14, 2016

Add validator for ISSNs.

Currently validates ISSNs of the form 1234-567[8xX], will make it handle numbers without hyphens later when I have some free time.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.831% when pulling feb6d43 on hkwu:feature/isISSN into 57af262 on chriso:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.831% when pulling 85414a4 on hkwu:feature/isISSN into 57af262 on chriso:master.

@chriso
Copy link
Collaborator

chriso commented Oct 14, 2016

Thanks!

@chriso chriso merged commit ea7b270 into validatorjs:master Oct 14, 2016
@hkwu hkwu deleted the feature/isISSN branch October 14, 2016 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkwu @coveralls @chriso