Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chriso
Hi, I just found that
isDate()
returnsfalse
with'2016-02-20T16:23:48.5'
It is because...
dayOrYearMatches = str.match(/(^|[^:\d])[23]\d([^:\d]|$)/g);
matches
'-20T'
and fails.There was similar case
'2010-02-18T16:23:48.5'
In this case, the regex matches nothing.
So, I add
T
in the regex to match nth for the exceptional case.dayOrYearMatches = str.match(/(^|[^:\d])[23]\d([^T:\d]|$)/g);
Please feedback me whether I did right or not.
Thanks.