Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Unencode() HTML Function #509

Merged
merged 1 commit into from Feb 27, 2016
Merged

Adding Unencode() HTML Function #509

merged 1 commit into from Feb 27, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 26, 2016

Hello,

I appreciate this package, however it is missing a unencode function for HTML.
I have duplicated the encode function but in reverse.

Thank you for your hard work,

Brandon Marick
Application Developer
Intel Corporation

@ghost
Copy link
Author

ghost commented Feb 26, 2016

The npm run test runs successfully
The npm run coveralls results in:


=============================== Coverage summary ===============================
Statements   : 84.55% ( 1242/1469 )
Branches     : 57.56% ( 609/1058 )
Functions    : 68.16% ( 137/201 )
Lines        : 99.08% ( 1075/1085 )
================================================================================

/home/ad_brmarick/validator.js/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Bad response: 422 {"message":"Couldn't find a repository matching this job.","error":true}

An additional note, I could not build this on a windows system. I had to use a Linux system.
Please let me know if I missed anything

Thank you,
Brandon Marick
Application Developer
Intel Corporation

@chriso
Copy link
Collaborator

chriso commented Feb 27, 2016

Thanks. In what way do the tests fail on windows?

The npm run coveralls command is for Travis CI: https://travis-ci.org/chriso/validator.js. The npm test command is the way to invoke unit tests locally.

@chriso chriso merged commit 59df9af into validatorjs:master Feb 27, 2016
@ghost
Copy link
Author

ghost commented Feb 29, 2016

There is error information I receive:

$ npm run test

> [email protected] pretest c:\...\validator.js
> npm run lint && npm run build


> [email protected] lint c:\...\validator.js
> eslint src test


> [email protected] build c:\...\validator.js
> npm run build:browser && npm run build:node


> [email protected] build:browser c:\...\validator.js
> babel-node build-browser && npm run minify

c:\...\validator.js\build-browser.js:12
}).then(bundle => bundle.write({
               ^^
SyntaxError: Unexpected token =>
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at loader (c:\...\validator.js\node_modules\babel-cli\node_modules\babel-register\lib\node.js:128:5)
    at Object.require.extensions.(anonymous function) [as .js] (c:\...\validator.js\node_modules\babel-cli\node_modules\babel-register\lib\node.js:138:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at c:\...\validator.js\node_modules\babel-cli\lib\_babel-node.js:161:27
    at Object.<anonymous> (c:\...\validator.js\node_modules\babel-cli\lib\_babel-node.js:162:7)
    at Module._compile (module.js:460:26)

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "c:\\Program Files\\nodejs\\\\node.exe" "c:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build:browser"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] build:browser: `babel-node build-browser && npm run minify`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build:browser script 'babel-node build-browser && npm run minify'.
npm ERR! This is most likely a problem with the validator package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel-node build-browser && npm run minify
npm ERR! You can get their info via:
npm ERR!     npm owner ls validator
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     c:\...\validator.js\npm-debug.log

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "c:\\Program Files\\nodejs\\\\node.exe" "c:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "build"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] build: `npm run build:browser && npm run build:node`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build script 'npm run build:browser && npm run build:node'.
npm ERR! This is most likely a problem with the validator package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build:browser && npm run build:node
npm ERR! You can get their info via:
npm ERR!     npm owner ls validator
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     c:\...\validator.js\npm-debug.log

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "c:\\Program Files\\nodejs\\node.exe" "c:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "run" "test"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE
npm ERR! [email protected] pretest: `npm run lint && npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] pretest script 'npm run lint && npm run build'.
npm ERR! This is most likely a problem with the validator package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run lint && npm run build
npm ERR! You can get their info via:
npm ERR!     npm owner ls validator
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     c:\...\validator.js\npm-debug.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant