Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-fix: revert #1167 #1355

Merged
merged 1 commit into from
Jun 11, 2020
Merged

hot-fix: revert #1167 #1355

merged 1 commit into from
Jun 11, 2020

Conversation

profnandaa
Copy link
Member

@profnandaa profnandaa commented Jun 11, 2020

coz of backward compatibility issue #1354

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

coz of backward compatibility issue #1354
@profnandaa
Copy link
Member Author

profnandaa commented Jun 11, 2020

@chriso -- proposing this revert on #1167 as a stop-gap measure for now; since quite a number of users have been affected with the 13.1.0 release. If this okay, you can merge; as we wait for @MladenZeljic to send in a fix.

Apologies, this was an oversight from my end.

@chriso chriso merged commit bdaeced into master Jun 11, 2020
@chriso chriso deleted the hot-fix-1354 branch June 11, 2020 20:50
@chriso
Copy link
Collaborator

chriso commented Jun 11, 2020

13.1.1 is now available. Thanks for determining the issue so quickly and submitting a patch.

Apologies, this was an oversight from my end.

No probs! I had no idea about the lookbehind incompatibility either. It'd be great to somehow test the browser version against various browsers/platforms, but not sure how feasible that is with the current CI setup.

@profnandaa
Copy link
Member Author

We're discussing with @tux-tn about the easiest way we could add some form of browser tests. #1354 (comment)

I noticed that the same commit was regressing on Node v6.17.1, so I'm adding this version on the list of our builds for the time being. This could act as a proxy for old/not-so-progressive browsers.

profnandaa pushed a commit that referenced this pull request Jun 27, 2020
Redo bs_BA locale due to the previous revert #1355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants