Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Costa Rica mobile phone added. #1279

Merged
merged 8 commits into from
Apr 4, 2020
Merged

Conversation

iErick99
Copy link
Contributor

@iErick99 iErick99 commented Apr 4, 2020

No description provided.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib!🎉 Could you please do the following:

  • move this up to the alphabetic order, before es-ES
  • add some tests
  • add the locale on the README.md

@iErick99
Copy link
Contributor Author

iErick99 commented Apr 4, 2020

Thanks for your contrib!🎉 Could you please do the following:

  • move this up to the alphabetic order, before es-ES
  • add some tests
  • add the locale on the README.md

Thank you for the reply, I think I have done all these tasks already.
I have to mentioned that I moved 'es-CR' after 'es-CL' based on what you say about alphabetic order, if I am wrong let me know and I will change it again.

@profnandaa
Copy link
Member

@iErick99 -- sure, order looks good. How about the tests and updating the README.md (L135)?

@iErick99
Copy link
Contributor Author

iErick99 commented Apr 4, 2020

@iErick99 -- sure, order looks good. How about the tests and updating the README.md (L135)?

Oh god... forgive me, I thought I had commited the other changes too, now it should be done, sorry for the inconvenience!

@profnandaa
Copy link
Member

No worries. Thanks for your contrib and welcome to the project! 🎉

@profnandaa profnandaa merged commit ac7620a into validatorjs:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants