Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce stricter Ecuador phone number validation #1191

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Enforce stricter Ecuador phone number validation #1191

merged 2 commits into from
Nov 5, 2019

Conversation

mmena1
Copy link
Contributor

@mmena1 mmena1 commented Oct 30, 2019

This will enforce stricter Ecuador phone number validation. @tux-tn
Closes #1190

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the edge cases discussed in #1187

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! 🎉

@profnandaa profnandaa merged commit 5b4a95f into validatorjs:master Nov 5, 2019
@mmena1 mmena1 deleted the stricter-ecuador-phone-number-validation branch November 5, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stricter Ecuador phone number validation
3 participants