Clean PR 1014 relating to fixing BR postal Code #1082
Conversation
ezkemboi
force-pushed
the
chore-clean-1014
branch
4 times, most recently
from
aa26332
to
8f87034
Compare
src/lib/isPostalCode.js
Outdated
| @@ -12,7 +12,7 @@ const patterns = { | |||
| AU: fourDigit, | |||
| BE: fourDigit, | |||
| BG: fourDigit, | |||
| BR: /^\d{5}-\d{3}$/, | |||
| BR: /^\d{5}(-\d{3})$/, | |||
There was a problem hiding this comment.
@bloodf added a regex where it made sure that it will allow -, . , | as a separator.
From my own research, I realized there are no cases where the separator was not -.
That is why I removed some of his changes.
Cc. @profnandaa.
There was a problem hiding this comment.
What's the use of the brackets (, )?
There was a problem hiding this comment.
To catch the
-\d{3}as a group.
There was a problem hiding this comment.
But, I don't know what it means by , you have made in the comment.
There was a problem hiding this comment.
Was wondering why we need to catch the group, I'm I missing something? 🤔
There was a problem hiding this comment.
That is true @profnandaa, I have updated it.
| @@ -6719,6 +6719,14 @@ describe('Validators', () => { | |||
| '22040-020', | |||
| '39400-152', | |||
| ], | |||
| invalid: [ | |||
There was a problem hiding this comment.
I also made sure that I added tests for invalid cases. Just for safety.
Cc. @profnandaa.
- fix issues relating to BR postal code - add more tests - closes validatorjs#1014
ezkemboi
force-pushed
the
chore-clean-1014
branch
from
8f87034
to
6333c94
Compare
|
@profnandaa, it seems that I have reverted the changes made by @bloodf. |
|
Good catch @ezrqnkemboi |
|
Yea, sure @profnandaa. |
Cleans issues arose from PR #1014.