Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#990. Clean up PR #991 #1052

Merged
merged 3 commits into from
Jul 1, 2019
Merged

#990. Clean up PR #991 #1052

merged 3 commits into from
Jul 1, 2019

Conversation

ezkemboi
Copy link
Member

This PR adds tests and updates readme for PR #991, which solves the issue raised under issue #990.

closes #991

profnandaa
profnandaa approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa
Copy link
Member

Thanks for the clean-up @ezrqnkemboi

/cc @luckyluck

@profnandaa profnandaa merged commit f3f4070 into validatorjs:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezkemboi @profnandaa @luckyluck