Add capability of logging multiple emails #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for making this! I’m new to Elixir and Phoenix but enjoying building an application with TDD. I trigger two emails when a person creates an account in the application: one to the new person, and one to the administrator. So the current implementation where the JSON log file is replaced for each email prevents me from testing for both emails.
I realise this is a significant change and would break anyone’s application that relies on the current implementation. I could add another configuration flag to turn on this functionality? I figured I’d start with this possibility and seek your input. I had to add a step to delete the log file if it existed, which is a bit cumbersome.
Also, since I’m so new to the language, I am still learning the idioms; let me know if I’ve written anything in an awkward way.