Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability of logging multiple emails #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

backspace
Copy link

Hey, thanks for making this! I’m new to Elixir and Phoenix but enjoying building an application with TDD. I trigger two emails when a person creates an account in the application: one to the new person, and one to the administrator. So the current implementation where the JSON log file is replaced for each email prevents me from testing for both emails.

I realise this is a significant change and would break anyone’s application that relies on the current implementation. I could add another configuration flag to turn on this functionality? I figured I’d start with this possibility and seek your input. I had to add a step to delete the log file if it existed, which is a bit cumbersome.

Also, since I’m so new to the language, I am still learning the idioms; let me know if I’ve written anything in an awkward way.

@bprotas
Copy link

bprotas commented Aug 9, 2016

I would really like this functionality as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants