Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment is wrong at this place #3

Open
mmpataki opened this issue Nov 7, 2017 · 0 comments
Open

Comment is wrong at this place #3

mmpataki opened this issue Nov 7, 2017 · 0 comments

Comments

@mmpataki
Copy link

mmpataki commented Nov 7, 2017

word2vec_commented/word2phrase.c

Line 108 in 07e9576

* hash = ((((h * 257) + a) * 257) + t) % 30E6

The comment says that for word 'hat'

(((h * 257) + a) * 257 + t)

but the code has hash initialized to 1 which makes the comment wrong

By the way thank you very much for comments sir. 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmpataki