Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable undefined error #4

Open
dgwyer opened this issue Apr 24, 2018 · 5 comments
Open

Variable undefined error #4

dgwyer opened this issue Apr 24, 2018 · 5 comments

Comments

@dgwyer
Copy link

dgwyer commented Apr 24, 2018

After the plugins have been downloaded I'm seeing errors for the $urls variable being undefined in the SizeCheck class.

Notice: Undefined variable: urls in C:\WordPress-Plugin-Directory-Slurper-master\update.php on line 368

Anyone have an idea as to why this might be occurring?

errors

@chriscct7
Copy link
Owner

The $this->urls is undefined because I believe this line https://github.com/chriscct7/WordPress-Plugin-Directory-Slurper/blob/master/update.php#L368 needs to be updated to
$this->urls = $files;

If that solves the issue, let me know and I can merge that in

@chriscct7
Copy link
Owner

Should've @dgwyer'd ^ that

@dgwyer
Copy link
Author

dgwyer commented Apr 25, 2018

It's OK I got your first message (probably because I created the issue). 😃

So changing $urls to $files sorted the sizecheck error but what I didn't notice yesterday (because the script didn't get that far) was that all the downloaded zip files are empty and therefore causing the script to fail at part 3 (unzipping).

empty-zips

script-fail

@dgwyer
Copy link
Author

dgwyer commented May 5, 2018

@chriscct7 Any ideas Chris?

@wrkinhrd
Copy link

Got similar results of 0kb for all downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants