Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement subtitle support #462

Open
chrisbenincasa opened this issue May 30, 2024 · 4 comments
Open

Reimplement subtitle support #462

chrisbenincasa opened this issue May 30, 2024 · 4 comments
Assignees
Labels
backend Pertains to the Tunarr server enhancement New feature or request size:xl Huge amount of work streaming Related to streaming features
Milestone

Comments

@chrisbenincasa
Copy link
Owner

Since we've removed the Plex transcoder, we need to bring back subtitle support with an 'in house' implementation. Of course, this is quite complicated, so we'll probably break it up into chunks:

  1. Support for external subtitles first. These are simplest because we can just pull the file from Plex and feed it into the stream.
  2. Support for extraction of embedded subtitles -- burning embedded subtitles into the output stream works well for local FS files (perhaps this can be an option with the 'direct' stream path), but when the stream input is coming from over the network, ffmpeg attempts to extract the subtitles out of the stream before playback starts, which is obviously a non-starter (it delays the stream)
  3. Exposing these options and capabilities in the UI to some degree (e.g. "enable burn-in", background task configuration)
@chrisbenincasa chrisbenincasa added enhancement New feature or request backend Pertains to the Tunarr server streaming Related to streaming features size:xl Huge amount of work labels May 30, 2024
@chrisbenincasa chrisbenincasa self-assigned this May 30, 2024
@chrisbenincasa chrisbenincasa pinned this issue Nov 23, 2024
@ameturpoet
Copy link

I would love to see subtitles support in Tunarr - it makes it a lot harder to make anime channels without subtitles. Maybe an option for selecting a default audio track, too?

@cameronurnes
Copy link

Would love this, we pretty much always run with subtitles on my dizquetv setup

@avedor
Copy link

avedor commented Jan 6, 2025

I don't really have much experience with typescript, but I'm happy to take a stab at getting external subs working!

@chrisbenincasa chrisbenincasa added this to the 0.18.0 milestone Jan 10, 2025
@chrisbenincasa
Copy link
Owner Author

@avedor PRs always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Pertains to the Tunarr server enhancement New feature or request size:xl Huge amount of work streaming Related to streaming features
Projects
None yet
Development

No branches or pull requests

4 participants