-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Remove" unneeded code for stateless boilerplate #372
Comments
alternative is to strip it down to be stateless, then move example stuff to a separate repo or a branch |
"The simplicity is the ultimate sophistication." simplify master, setup feature branches for add-ons (Mongo, Vote-App, Todo-App, etc.) personally, the first thing I did was flatten Or... Setup an ORG and do repo's instead of branches 👍 |
Ok, apparently I closed my window before hitting the comment button earlier. 😑 So enjoy my now less thoughtful comments. I am embarrassed to admit how long I had the todo code sitting inside my app for reference, so I think it is indispensable resource. There are myriad boilerplates out there that focus on getting you up and running, but most of them are blog fodder. They don't focus on best practices, helping you understand how or you should be coding, and the certainly aren't getting better. I evaluated quite a few before I settled on this on this one. So I totally agree with @jrodl3r and @psimyn. I would going to suggest the multiple repos, and allowing the stateless version to live upstream of the more tutorial oriented version. I hadn't considered the idea of an ORG, but I think that is actually a really good idea, if we are splitting this in to multiple repositories then that is essentially what we are doing anyway. It would allow us the freedom to structure things properly. Also I know there is the Yeoman Generator created by @iiegor. I don't know how up to date it is/ if it stays up to date as this repo gets updated. One option would be to use that (or some version of it) or even better, our own command line tool (never built one, sounds like a neat idea, and if we are going to be an org, then a command line tool and mascot are basically mandatory) that would allow people to pick and choose which features they might want included. Everyone ready for an adventure? |
Thanks for the suggestions guys!
Agreed
Hahaha this should be the next thing after we port our repos over! Important question What should the organisation name be?
This thread might get long lol based on the suggestions. I will create an org as soon as we agree on one. In the meantime, will start a branch with 2.0 clean branch :) |
reactis |
Couldnt' resist. Here's what the new version would look like without db config or passport. Still going to clean up the client side to just have react-router but no routes or functionality. Once we reduce to the final features we can evaluate to see that's what we want. |
🚤 NinjaShip something small, easy to type... |
I will now come up with several terrible names
I think Practical React might not be terrible, but I will try to come up with better ones later. edit: I was hesitant to add express a part of the naming because I thought that would limit us from eventually moving over to Koa if we felt like that was a good idea. And similarly I left out redux, because while it is super awesome, it wasn't the first flux implementation this boilerplate used, and I don't think it will be the last. |
@caranicas I might have been a little aggressive with my example branch/repo-names 😉 The core-logic and working demo is obviously a key piece to getting people up and running quickly. That should have read: (Mongo, Postgres, Stripped/Barebones, etc) Down the road we can easily add repo's that swap-out core-logic (ex: "HNews-App" or "Todo-App") |
I like that RNEW!
I'm so cheating w/ Enzyme... heh |
my list of more esoteric names focused on theme of modular, easy to read and well intentioned code.
I'll keep thinking.... |
LOL guys, loving the creativity! I really like ReactUp and ReactGo, cause it's simple and concise! (And on an unrelated note, I kinda am addicted to Pokemon Go). What do you guys think? |
Vote for ReactGO |
Vote for |
Suggested Support And repository NamesReactGo - minimal
Separate repositories Mongo
Postgres
Socket IO |
just me, but I'd startup the org first, then start 2.0 issues, etc over there... |
@jrodl3r Good point. I was kind of spec-ing out what to separate first though. Agree that it will make more sense to create the issues there. I've created the org reactGo on the train this morning. Should it be called
etc. Suggestions for that haha. I'd like to transfer that repository or point to the repository from here once it's done. |
the best band's first album is always self-titled ; ) "reactGo" |
Created https://github.com/reactGo/reactGo, but I am thinking of transferring this repository to that once we have a minimal boilerplate out (so there will be redirects) when people come to this repository. (Not sure whether this is the correct approach, but that's how redux-simple-router was renamed and moved to reactjs) |
Hey guys, just created a doc to have a bit more visibility on what I have in mind for reactGo. https://github.com/choonkending/react-webpack-node/blob/master/Roadmap.md Please review. I'm going to transfer the repository to reactGo, and we will work on release 2.0 over there? (As @jrodl3r suggested). What do you peeps think? (Meanwhile I'm going to try to solve other issues raised here). |
Looks good, vision sounds great... I'll volunteer a nice responsive/flat-UI for the App-Example 🍻 |
It's done! I've moved it 😂 😢 We're now reactGo! Yay! |
Closing in favour of https://github.com/reactGo/reactGo/projects/1 and the cards on that wall! |
Description
Enhancement
Was looking an create-react-app and was inspired by the No Lock-In idea.
Problem
There is still a lot to strip out when cloning this boilerplate.
The code that sits in this repository are useful examples of how one would implement certain features with the best practices - we strive for that.
However, I still find myself stripping out a lot of code I don't need.
We've already done a decent job with abstracting out the DB connection in #176 and #190
Suggested enhancement
Have an
npm run stateless
that:rimraf
to remove all the unneeded:If this gets shipped, and it works swimmingly well, I reckon we can bump our version to 2.0! Yay!
Pros
Including
@caranicas @psimyn @jrodl3r @dzotokan and whoever has thoughts!
The text was updated successfully, but these errors were encountered: