Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces are incorrectly stripped #72

Closed
pfrazee opened this issue May 10, 2017 · 4 comments · Fixed by #74
Closed

Spaces are incorrectly stripped #72

pfrazee opened this issue May 10, 2017 · 4 comments · Fixed by #74

Comments

@pfrazee
Copy link

pfrazee commented May 10, 2017

253d352 This commit is pulling out spaces that we need.

screen shot 2017-05-10 at 2 34 59 pm

There are a couple of examples in there; ie '1addition' should be '1 addition'.

@mantoni
Copy link
Contributor

mantoni commented May 12, 2017

This was introduced in #68 and there is a related issue in yo-yoify: shama/yo-yoify#48

@yoshuawuyts
Copy link
Member

uh oh, this is no good - back from holiday tomorrow - will take a look into fixing this then C: - sorry for the inconvenience!

@mantoni
Copy link
Contributor

mantoni commented May 16, 2017

No worries. I just pinned the version number for now.

@kemitchell
Copy link
Contributor

This one got me, too. I was able to work around it with explicit document.createTextNode(' ') between <span> templates.

No pressure on this at all. Really appreciate everyone's work. I figure @yoshuawuyts has the Deep Knowledge on this and where to go with it, since the commit was his. But in case I'm wrong, just let me know. I can try and cook up a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants