Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pass internal state object to barracks when calling start() #141

Closed
yoshuawuyts opened this issue Jul 7, 2016 · 1 comment
Closed

Comments

@yoshuawuyts
Copy link
Member

Expected behavior

Rehydration should be possible without passing an empty state object to barracks - means we're running an extra for loop on startup and not a fan of the extra overhead - signals something is broken and we used ducktape to fix it.

Actual behavior

This line is required - https://github.com/yoshuawuyts/choo/blob/master/index.js#L65

Steps to reproduce behavior

Remove the line, run the tests

@yoshuawuyts yoshuawuyts added the bug label Jul 7, 2016
@yoshuawuyts yoshuawuyts changed the title don't pass state to don't pass internal state object to barracks when calling start() Jul 7, 2016
@yoshuawuyts
Copy link
Member Author

Closing because choo@5 will introduce a new API. See #425 for the merged PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant