write to the correctly scoped chocolateyErrored variable

[mwrock]

Exceptions raised in chocolateyInstall.ps1 are not resulting in a non-zero exit code because it is writing to the $chocolateyErrored variable in a different scope from where it was created. To illustrate, the added test in this PR will fail if Chocolatey-Nuget.ps1 is reverted.

[ferventcoder]

None of this code exists in choco.exe :(

[mwrock]

Right but it fixes the PS version. When is choco.exe due?

[ferventcoder]

January 15th-ish

[mwrock]

Oh ok. As a full release or alpha/beta?

Sent from my Windows Phone

---

From: Rob Reynoldsmailto:[email protected]
Sent: ‎1/‎12/‎2015 8:46 AM
To: chocolatey/chocolateymailto:[email protected]
Cc: Matt Wrockmailto:[email protected]
Subject: Re: [chocolatey] write to the correctly scoped chocolateyErrored variable (#658)

January 15th-ish

---

Reply to this email directly or view it on GitHub:
#658 (comment)

[ferventcoder]

Well likely a beta.

On Monday, January 12, 2015, Matt Wrock [email protected] wrote:

Oh ok. As a full release or alpha/beta?

Sent from my Windows Phone

---

From: Rob Reynolds<mailto:[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
Sent: ‎1/‎12/‎2015 8:46 AM
To: chocolatey/chocolatey<mailto:[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
Cc: Matt Wrock<mailto:[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
Subject: Re: [chocolatey] write to the correctly scoped chocolateyErrored
variable (#658)

January 15th-ish

---

Reply to this email directly or view it on GitHub:
#658 (comment)

—
Reply to this email directly or view it on GitHub
#658 (comment).

Rob
"Be passionate in all you do"

http://devlicio.us/blogs/rob_reynolds
http://ferventcoder.com
http://twitter.com/ferventcoder

[mwrock]

ok cool. Wasn't sure if there is stuff out there that would be highly impacted by a lack of a non-zero error code. I pushed a work around in boxstarter last night so its not affected.

[ferventcoder]

I will likely go ahead on this one.

[ferventcoder]

This looks like a fix for #568 (ha, transposed! Wild!)

[ferventcoder]

Merged into stable at bcea921

[matt-richardson]

Thanks @ferventcoder!

[ferventcoder]

Released as well a little while ago.