Package Builder / sync - choco sync fails to build some packages depending on the application's name + invalid exit code of choco.exe

[mwallner]

ref: chocolatey/choco#1666

What You Are Seeing?

when running choco sync a couple of applicaitons in programs and features are not synced - choco.exe returns with exit code 0, but some errors are noted

What is Expected?

choco sync should be able to create "dummy-packages" for all applications in programs and features

• if there are errors, a non-zero exit code should inidcate that

Output Log

D:\work\choco> choco sync | Tee-Object chocosync.txt
Chocolatey v0.10.11 Business

Chocolatey is going to sync your system against Programs and Features,
 generating packages and updating them against existing packages or
 baselining as new packages on the fly. When this run is complete,
 you will have access to use the package output to use for source
 control.

 - Synced existing 'intellij-idea-community' package successfully with 'IntelliJ IDEA Community Edition 2017.3.3'.
 - Synced existing 'sourcetree' package successfully with 'SourceTree'.
 - Synced new 'qt' package successfully with 'Qt'.
Unable to sync 'AutoHotkey'. There was an existing package found but now unable to load it.
 - Synced existing 'python-anaconda3' package successfully with 'Python 3.6.5 (Anaconda3 5.2.0 64-bit)'.
 - Synced existing 'javatm-se-development-kit' package successfully with 'Java(TM) SE Development Kit 10.0.1 (64-bit)'.
 - Synced existing 'keepassxc' package successfully with 'KeePassXC'.
Unable to sync 'VeraCrypt'. There was an existing package found but now unable to load it.
 - Synced existing 'microsoft-sql-server-compact-sp2-deu' package successfully with 'Microsoft SQL Server Compact 3.5 SP2 DEU'.
 - Synced existing 'microsoft-visual-cplusplus-redistributable' package successfully with 'Microsoft Visual C++ 2013 Redistributable (x64) - 12.0.30501'.
 - Synced existing 'pandoc' package successfully with 'Pandoc 2.1.3'.
 - Synced existing 'microsoft-dotnet-core-sdk' package successfully with 'Microsoft .NET Core SDK - 2.1.202 (x64)'.
 - Synced existing 'microsoft-dotnet-core-sdk' package successfully with 'Microsoft .NET Core SDK 2.1.400 (x64)'.
Unable to build a package for Command & ConquerT: Generals and Zero Hour 1.0.0.0:
   The package ID 'command-amp;-conquer-generals-and-zero-hour' contains invalid characters. Examples of valid package IDs include 'MyPackage' and 'MyPackage.Sample'.
 - Synced existing 'windows-software-development-kit-windows' package successfully with 'Windows Software Development Kit - Windows 10.0.16299.15'.
 - Synced existing 'microsoft-dotnet-core-runtime' package successfully with 'Microsoft .NET Core Runtime - 2.1.2 (x64)'.
 - Synced existing 'microsoft-dotnet-core-runtime' package successfully with 'Microsoft .NET Core Runtime - 2.1.2 (x86)'.
 - Synced existing 'microsoft-visual-cplusplus-redistributable' package successfully with 'Microsoft Visual C++ 2017 Redistributable (x86) - 14.15.26706'.
 - Synced existing 'microsoft-dotnet-core-sdk' package successfully with 'Microsoft .NET Core SDK - 2.1.2 (x64)'.
 - Synced existing 'microsoft-dotnet-core-sdk' package successfully with 'Microsoft .NET Core SDK - 2.1.4 (x64)'.
 - Synced existing 'microsoft-dotnet-core-runtime' package successfully with 'Microsoft .NET Core Runtime - 2.0.7 (x64)'.
 - Synced existing 'microsoft-dotnet-core-sdk' package successfully with 'Microsoft .NET Core SDK - 2.1.201 (x64)'.
 - Synced existing 'microsoft-visual-cplusplus-2010-redistributable' package successfully with 'Microsoft Visual C++ 2010  x86 Redistributable - 10.0.40219'.
Unable to build a package for LEGO MINDSTORMS NXT Software v2.0 2.0.133.0:
   Unerwartetes Token '='. Erwartet wurde das Token ';'. Zeile 40, Position 64.
 - Synced existing 'microsoft-visual-cplusplus-redistributable' package successfully with 'Microsoft Visual C++ 2013 Redistributable (x86) - 12.0.30501'.
 - Synced existing 'microsoft-system-clr-types-for-sql-server-2017' package successfully with 'Microsoft System CLR Types for SQL Server 2017'.

Chocolatey synced 24 packages (generated 24 packages). Synced 21 existing packages. 4 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
Generated packages for source and source control are at
 D:\work\choco\sync
The following errors were noted:
* Unable to sync 'AutoHotkey'. There was an existing package found but now unable to load it.
* Unable to sync 'VeraCrypt'. There was an existing package found but now unable to load it.
* Unable to build a package for Command & ConquerT: Generals and Zero Hour 1.0.0.0:
   The package ID 'command-amp;-conquer-generals-and-zero-hour' contains invalid characters. Examples of valid package IDs include 'MyPackage' and 'MyPackage.Sample'.
* Unable to build a package for LEGO MINDSTORMS NXT Software v2.0 2.0.133.0:
   Unerwartetes Token '='. Erwartet wurde das Token ';'. Zeile 40, Position 64.

D:\work\choco> $LASTEXITCODE
0

┆Issue is synchronized with this GitLab issue by Unito

[ferventcoder]

Thanks for writing this up. We have a release to get out the door and then we can come back around and take a closer look at this issue.