pack - URI encodes filenames

[Andreas-Schommer]

What You Are Seeing?

Choco pack encodes filenames different to nuget. Filenames are uri encoded in choco, Nuget leaves them intact.
There was an issue fixed in nuget addressing the same issue.
The created packages can be installed without problems (with nuget as well as with chocolatey).

I used nuget 4.7.0.5148 and chocolatey v0.10.11 to do the repro.

What is Expected?

Choco pack and nuget pack should handle filenames alike, filenames with special characters and spaces should be preserviced in the nupkg.

How Did You Get This To Happen? (Steps to Reproduce)

I created a nuspec file that contains files with special characters and spaces in their names:

I used nuget pack and choco pack to create the package.

When opening the nupkg created with nuget as a ZIP archive,, the filenames are the original filenames used to create the package.
When opening the nupkg created with choco as a ZIP archive, the filenames are URI encoded.

Repro.zip

This issue has been moved over from chocolatey/chocolatey.org.

[bcurran3]

I'm not an expert on NuGet so I'm not sure if this is relevant, but keep in mind that Chocolatey is based on NuGet v2. (Someone correct me if I'm wrong!)

[ferventcoder]

@Andreas-Schommer I think this would be an enhancement request. Chocolatey != NuGet, and we expect there to be differences between the two. We welcome opportunities to ensure they continue to have things that are the same, but keep in mind the expectation from us for edge cases is not that they should behave exactly alike. Does that make sense?

So far I don't really see where the issue is - opening up the archive with zips isn't a runtime scenario and isn't part of a supported installation method. But let's talk about areas where this could cause issues so we can better understand the use case.

[viceice]

Now this is a problem.

If i pack a folder with spaces with NuGet 4.9.2.5706 then chocolatey v0.10.11 will not extract that folder.

Regards
Michael

[viceice]

I found a workaround.

This does not work:

<file src="html\**\*.html" target="content/Style Library" />

This works:

<file src="html\**\*.html" target="content/Style%20Library" />

[rgl]

I'm also affected by this issue. A choco pack on a directory that contains file names with white spaces (which unfortunately is common on Unity generated projects, e.g. they normally have a file named unity default resources) works; but when you try to choco install it, it simply fails without any clue about the problem.

BTW, I'm not sure where you are seeing that choco URL encodes the filenames, but it doesn't do that with white spaces.

I'm using choco 0.10.13.

[TheCakeIsNaOH]

This was fixed as a part of v2.0.0, as the NuGet libraries were updated. I think this issue can be closed, as the NuGet library tests should cover this fuctionality?

[corbob]

This might actually be an OS issue... I do not experience this issue when testing with 1.4.0 (even with Chocolatey 0.10.11) on Windows 11... I do have the url encoding in the nupkg though...

This issue seems to actually require more repro steps. I have taken the repro.zip, put it on a 2012 R2 VM, and am unable to reproduce the issue with Chocolatey 0.10.11:

[corbob]

@Andreas-Schommer, @viceice, or @rgl, I realize this is a really old issue. Are any of you able to reproduce this issue still?

[viceice]

don't know, I no longer have spaces, so it's no longer an issue for me.

[pauby]

I'm going to go ahead and close this as stale, but we can reopen it if necessary.