Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation for Install-ChocolateyInstallPackage #1416

Closed
tcase opened this issue Oct 4, 2017 · 5 comments
Closed

Incorrect documentation for Install-ChocolateyInstallPackage #1416

tcase opened this issue Oct 4, 2017 · 5 comments

Comments

@tcase
Copy link

tcase commented Oct 4, 2017

Documentation for Install-ChocolateyInstallPackage is incorrect. It contains the following example:

.EXAMPLE

Install-ChocolateyInstallPackage -PackageName 'bob' -FileType 'exe' -SilentArgs '/S'
-File "$(Split-Path -Parent $MyInvocation.MyCommand.Definition)\bob.exe" `
-ValidExitCodes = @(0)

The -ValidExitCodes should not have the "=" in it

@danyelcampbell
Copy link

danyelcampbell commented Oct 11, 2017

Looking to get into helping in open source! This seems like an easy fix, mind if I do this?

@ferventcoder
Copy link
Member

ferventcoder commented Oct 11, 2017

@danyelcampbell not at all, the code is at

Install-ChocolateyInstallPackage -PackageName 'bob' -FileType 'exe' `
-SilentArgs '/S' `
-File "$(Split-Path -Parent $MyInvocation.MyCommand.Definition)\bob.exe" `
-ValidExitCodes = @(0)

Please make sure you read over all of https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md first. There are some important details in there, especially surrounding how to form your commit messages.

@danyelcampbell
Copy link

I've changed it and did my commit, however, I'm having issues pushing it. I'm getting "unable to access 'https://github.com/chocolatey/choco.git/': The requested URL returned error: 403" I've googled it with no successful results.... ):

@joshuaobrien
Copy link
Contributor

@danyelcampbell be sure to read over https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md. You'll need to create a fork

@danyelcampbell
Copy link

danyelcampbell commented Oct 14, 2017

I've already created my fork and made the commit. I'm trying to push but when I do I get a permissions issue...working through that now..

EDIT: It's done! I downloaded the GitHub Desktop instead of working with GitHub Bash and everything is good now! This was a fun learning process 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants