[BUG] Unzip specific folder feature is broken after introducing 7zip

[AnthonyMastrean]

I'm updating a package that downloads an archive with x64 and Win32 subdirectories. I used to extract the entire thing and manually remove the unneeded components. But, I figured I would try the as-yet undocumented -specificFolder parameter of Install-ChocolateyZipPackage.

$name   = "bellavista"
$url    = "http://.../bellavista.zip"
$tools  = Split-Path $MyInvocation.MyCommand.Definition
$folder = if(Get-ProcessorBits 64) { "x64" } else { "Win32" }


Install-ChocolateyZipPackage -PackageName $name -Url $url -UnzipLocation $tools -SpecificFolder $folder

But, it didn't work. The first thing I saw was a goofy log message. Look at the "full path" in bold. It contains a non-path

"Extracting c:\users\foo\temp\chocolatey\bellavista\bellavistaInstall.zip\x64 to c:\Chocolatey\lib\bellavista.1.0\tools..."

And, digging in the source, I saw a bad 7za command line being constructed

7za x -o"c:\Chocolatey\lib\bellavista.1.0\tools" -y "c:\users\foo\temp\chocolatey\bellavista\bellavistaInstall.zip\x64"

From my reading of the command line reference, and hacking my helper function, the correct command line should be...

7za x "c:\users\foo\temp\chocolatey\bellavista\bellavistaInstall.zip -o"c:\Chocolatey\lib\bellavista.1.0\tools" "x64" -y

And, actually, with this fix, you could supply any glob pattern to 7za, not just a specific folder.

[AnthonyMastrean]

I can supply the patch if you agree it's broken :)

[rismoney]

I say go ahead! I added the -specificfolder switch before we went 7za so imho it's a regression.

[AnthonyMastrean]

Can I use pester to mock the 7za call?

[mwrock]

yes.

Mock 7za

[AnthonyMastrean]

OMG, it's that easy, huh? I guess powershell isn't treating native commands differently than cmdlets, it's interpreting everything and if it finds my mock first, I win, right?

Actually... am I able to mock a full file path? The script joins together everything down to the .exe.

$7zip = Join-Path "$env:ChocolateyInstall" 'chocolateyinstall\tools\7za.exe'

Nevermind, I'm mocking Start-Process instead, got it ;)

[mwrock]

You win!! :)

Yeah as long as you can do a

Get-Command 7za

it should work. Pester creates a proxy command and hides the original command.

[ferventcoder]

Undocumented means unsupported ;)

[ferventcoder]

AKA dark features. Actually I think this is probably undocumented b/c it's something we may have missed documenting... :(

[AnthonyMastrean]

I'll take care of that too ;)

[ferventcoder]

@AnthonyMastrean Did I miss the PR?

[AnthonyMastrean]

Nah, life attacked and I haven't gotten around to it or a million other things I want to work on ;) I do remember my initial patch not working entirely (there's a lot of quoting/escaping going on in the line in question). But, this can be a good reminder to get on it.

[ferventcoder]

I'm going to bump this to the next version while waiting for updates.

[rubenqba]

When is solved this issue??

[ferventcoder]

Migrated to chocolatey/choco#676