Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit status when the amount of input data is too small #143

Open
classic-mcfly opened this issue Dec 7, 2020 · 4 comments
Open

exit status when the amount of input data is too small #143

classic-mcfly opened this issue Dec 7, 2020 · 4 comments

Comments

@classic-mcfly
Copy link

The chloroExtractor terminates with exit status 1 if the input dataset is too small which terminates the whole nextflow pipeline if the errors are not set to be ignored.

@iimog
Copy link
Member

iimog commented Dec 17, 2020

Interesting. So your nextflow pipeline would be able to deal with the situation that chloroExtractor failed due to lack of input data? We could consider terminating because of this reason as a valid outcome with exit status 0. So far I considered it a kind of failure but I see the point in changing it. @greatfireball do you have an opinion on this subject?

@iimog
Copy link
Member

iimog commented Dec 17, 2020

We only need to change one character here 😃

@greatfireball
Copy link
Member

I already told @MarvinMcFly :)

Nevertheless, due to it changes the behavior, we should both agree to that change. My suggestion would be to add another option (die-without-error-state), which will exit with a code of 0 instead of 1. As default, we are able to still exit with 1

@iimog
Copy link
Member

iimog commented Dec 17, 2020

Fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants