Add Integration for Create QR Code, Update QR Code, Overseas Query, Spot Refund #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing. This new methods didn't affect other method usage, so I'm happy to merge. A few more questions before merging:
|
|
Yeap, these codes are running in production environment Ok, will add some tests |
|
HI @chloerei , @kahshing96 has added some unit tests, maybe you can take a look at it to see if it's ok to merge? |
|
Looks good, I'll release a new version later. |
|
Sorry I didn't setup CI before, when I run test local, I found test fails: I can simply modify the test case to make it pass, but want to confirm whether your local test also has this error? |
hmm weird, i am able to pass the test locally i think the issue should be the ➜ alipay git:(master) bundle exec rake
/Users/kschee/Workspace/fave/alipay/lib/alipay/utils.rb:26: warning: assigned but unused variable - exception
Run options: --seed 38168
# Running:
......................................................
Finished in 0.629430s, 85.7919 runs/s, 95.3243 assertions/s.
54 runs, 60 assertions, 0 failures, 0 errors, 0 skips |
|
@kahshing96 You are running test on master, can you test on branch FAVE-27624-rebase-original-repo ? I test fail after pull the branch local. |
|
@chloerei work for me ➜ alipay git:(chore/FAVE-27624-rebase-original-repo) ✗ bundle exec rake
/Users/kschee/Workspace/fave/alipay/lib/alipay/utils.rb:26: warning: assigned but unused variable - exception
Run options: --seed 57383
# Running:
......................................................
Finished in 0.275448s, 196.0443 runs/s, 217.8270 assertions/s.
54 runs, 60 assertions, 0 failures, 0 errors, 0 skips |
|
@kahshing96 I think it's the timezone. I think it should use |
|
@chloerei i think you're right, it was due to the timezone which cause the test failed, let me try create a new PR for this |
Merged
|
v0.17.0 is released! https://github.com/chloerei/alipay/releases/tag/v0.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Documentation
https://global.alipay.com/docs/ac/global/qrcode_create
https://global.alipay.com/docs/ac/global/qrcode_modify
https://global.alipay.com/docs/ac/global/overseas_query
https://global.alipay.com/docs/ac/global/spot_refund