Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SkippingReason field in the SkippedTasks field of PipelineRunStatus. #1

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

chitrangpatel
Copy link
Owner

@chitrangpatel chitrangpatel commented Apr 26, 2022

To address the TEP and issue.
Skipping Reason included in the SkippedTasks field of PipelineRunStatus.

Prior to this, users only knew that a PipelineTask was skipped but not
the exact reason for skipping the task leading to confusion when
debugging Pipelines.

This commit adds a field Reason of type SkippingReason (a string alias) to the SkippedTasksfield in PipelineRunStatus. The tests have been updated to validate skipping reason.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

…tatus`.

Prior to this, users only knew that a `PipelineTask` was skipped but not
the exact reason for skipping the task leading to confusion when
debugging `Pipelines`.

This commit adds a field `Reason` of type [`SkippingReason`][reasons] (a string alias) to the [`SkippedTasks`][skipped-tasks] field in `PipelineRunStatus`.
@chitrangpatel chitrangpatel merged commit af71639 into main Apr 26, 2022
chitrangpatel pushed a commit that referenced this pull request Jul 5, 2022
Required fields and related webhook validations are added to support
a user to configure compute resources for TaskRun which will significantly
reduce the over-asked resources amount configured by the Step-level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant