Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safeTransferFrom, approve, transferFrom external payable? #424

Open
vakkuda opened this issue Sep 17, 2022 · 6 comments
Open

safeTransferFrom, approve, transferFrom external payable? #424

vakkuda opened this issue Sep 17, 2022 · 6 comments

Comments

@vakkuda
Copy link

vakkuda commented Sep 17, 2022

Are they supposed to be external payable? Imported then flattened in Remix 9/17/22 wasn't previous versions
external payable

@Vectorized
Copy link
Collaborator

I think you need to right-click + delete the deps folder for the files to be redownloaded.

@tomazmm
Copy link

tomazmm commented Nov 24, 2022

Since these functions are payable, they are not compatible with function signatures that OpenSea wants for their new Creator Fees system.

https://github.com/ProjectOpenSea/operator-filter-registry

Edit:
Ignore my comment. It was a product of me being tired and stressed.

@cygaar
Copy link
Collaborator

cygaar commented Nov 24, 2022

Payable is unrelated to the new OpenSea policies. If you're talking about their specific filtering library, ERC721A still works. You just need to add the modifier to your transfer functions.

@tomazmm
Copy link

tomazmm commented Nov 24, 2022

That's also what I thought. For some reason opensea thinks, I did not include Creator Fees functions.

@Vectorized
Copy link
Collaborator

@tomazmm If you want an optimized example using ERC721A, may I interest you in https://github.com/Vectorized/closedsea ;)

@tomazmm
Copy link

tomazmm commented Nov 25, 2022

Oh cool. Will definitly look into it. I love your work and contribution. Much respect 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants