Skip to content

Commit

Permalink
refactor(ideations.controller.spec.ts, ideations.service.spec.ts): re…
Browse files Browse the repository at this point in the history
…move unused variables

The unused variables 'ideationArr' and 'ideationVoteArr' were removed from both ideations.controller.spec.ts and ideations.service.spec.ts. Also, the unused import 'ConflictException' was removed from ideations.service.spec.ts. These changes were made to clean up the code and improve readability.
  • Loading branch information
timDeHof committed Oct 28, 2024
1 parent 5217013 commit b1beb8a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
1 change: 0 additions & 1 deletion src/ideations/ideations.controller.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ describe("IdeationsController", () => {
createdAt: mockDate,
updatedAt: mockDate,
};
const ideationArr = [ideationOne];

const ideationVoteOne = { id: 1, projectIdeaId: 1 };

Expand Down
10 changes: 1 addition & 9 deletions src/ideations/ideations.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,7 @@ import * as VoyageTeamAbility from "@/ability/conditions/voyage-teams.ability";
import { prismaMock } from "@/prisma/singleton";

import { ProjectIdea, VoyageTeamMember, ProjectIdeaVote } from "@prisma/client";
import {
ForbiddenException,
NotFoundException,
ConflictException,
} from "@nestjs/common";
import { ForbiddenException, NotFoundException } from "@nestjs/common";

// TODO: these tests probably need to be updated, it shouldn't use prisma, should only use prismaMock
describe("IdeationsService", () => {
Expand Down Expand Up @@ -44,8 +40,6 @@ describe("IdeationsService", () => {
},
};

const ideationArr = [ideationOne];

const ideationVoteOne: ProjectIdeaVote = {
id: 1,
projectIdeaId: 1,
Expand All @@ -54,8 +48,6 @@ describe("IdeationsService", () => {
updatedAt: mockDate,
};

const ideationVoteArr = [ideationVoteOne];

const memberOne: VoyageTeamMember = {
id: 1,
userId: "00a10ade-7308-11ee-b962-0242ac120002",
Expand Down

0 comments on commit b1beb8a

Please sign in to comment.