Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize loading times #78

Open
SplendidAlakey opened this issue Jan 30, 2023 · 0 comments · May be fixed by #79
Open

Optimize loading times #78

SplendidAlakey opened this issue Jan 30, 2023 · 0 comments · May be fixed by #79
Labels
enhancement New feature or request

Comments

@SplendidAlakey
Copy link

Is your feature request related to a problem? Please describe.

Currently, adding Minekea even to a vanilla instance adds around 1min to the game's loading (30sec vanilla vs 1min30sec with Minekea). While it's not detrimental in this situation, once you start assembling a modpack, it quickly becomes an issue, as having a constant 1min of loading time added on top of everything else makes the loading take quite a bit of time.

Describe the solution you'd like

Initially, the issue was brought up to me by one of the Quilt developers @AlexIIL, as such the suggestion is not mine, but Minekea spends ~25 seconds compiling string patterns, which is the part, that could be optimized. This can be seen in a snapshot I captured with JVVM: snapshot_minekea_alone_fabric.zip

Describe alternatives you've considered

Additional context

@SplendidAlakey SplendidAlakey added the enhancement New feature or request label Jan 30, 2023
AlexIIL added a commit to AlexIIL/minekea-fabric that referenced this issue Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant