Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip customize files + set workdir #12

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Skip customize files + set workdir #12

merged 6 commits into from
Feb 27, 2024

Conversation

msanterre
Copy link
Contributor

@msanterre msanterre commented Feb 27, 2024

Skip the rendering of kustomize files, and adds the ability for users to set the work directory of the app.

Testing on chime-cd:
go run main.go hashing.go --workdir ../chime-cd/ -root=bootstrap/child-applications-us-east-1/devex-develop2 -output=zz.auto-generated/root-use1-devex-develop2/ -hash-store=json -ignore-suffix=-console -skip-render-key=appTag -ignore-value-file=overrides/apptags.

@msanterre msanterre requested a review from a team as a code owner February 27, 2024 05:11
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@msanterre msanterre force-pushed the skip-kustomize-files branch 2 times, most recently from ca3c85b to 762331d Compare February 27, 2024 18:02
Copy link
Collaborator

@Nicolas-Richard Nicolas-Richard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@d1egoaz d1egoaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

We really need to add unit tests to this.
Probably in the future, we need to keep working on https://github.com/1debit/mani-diffy/pull/9/files to make writing unit tests easier.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@msanterre msanterre merged commit 0db0789 into main Feb 27, 2024
5 checks passed
@msanterre msanterre deleted the skip-kustomize-files branch February 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants