-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why using $parent[0].lastChild #179
Comments
I'm not following the exact question, but the title of your issue is related to this commit: c21a146. Is this causing a problem? |
Yes, I have the same problem. It is now not possible to use an empty element for the parent. Also, it would be nice if one could use a query selector or an actual dom/jqlite.element object on parentSelector instead of |
I dont know -- that commit specifically was taken out of the Angular team's migration guide. Are you using an older version of angular? |
No, latest. Can you maybe post an example where the loading bar is injected into an empty element? It doesn't show up for me at all if there is no element within the |
Sorry for late reply, as omeid explained well enough, I'd like to use a generic selector instead of the parentSelector, so that we can inject the loader in any empty container. |
I've pointed this out before. Just never got the time to write CoffeeScript tests.. #170 (comment) |
Added the PR: #218 |
See pull 272. |
When trying to use a custom position for the loading bar, I must create two nested div in order for the bar to works (css are for demo only):
as this won't work:
Isn't it possible to append the bar to the currentSelector instead of parentSelector ?
The text was updated successfully, but these errors were encountered: