Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checksum verification for Godot downloads #58

Closed
Shaderbug opened this issue Apr 8, 2024 · 1 comment · Fixed by #59
Closed

Add checksum verification for Godot downloads #58

Shaderbug opened this issue Apr 8, 2024 · 1 comment · Fixed by #59
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Shaderbug
Copy link
Contributor

When installing a new Godot version, the checksum of the downloaded file is currently not checked.

I propose comparing them after download against the SHA-512 checksums published at https://github.com/godotengine/godot-builds/tree/main/releases.

I'll attempt to write a PR for this feature, expect it in at most 14 days, likely a lot sooner :)
@jolexxa jolexxa added enhancement New feature or request help wanted Extra attention is needed labels Apr 15, 2024
@Shaderbug
Copy link
Contributor Author

I'm missing my original estimate (life happened), but I'm making progress in my fork

@Shaderbug Shaderbug mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Checksum validation Shaderbug/GodotEnv
2 participants
@jolexxa @Shaderbug