Simplify conversions around arithmetic operators #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
binop_simplify_poc
branch
from
57b6bcc
to
043cc82
Compare
chfast
changed the title
chfast
changed the title
chfast
force-pushed
the
binop_simplify_poc
branch
2 times, most recently
from
6d79688
to
eb0eae1
Compare
chfast
force-pushed
the
binop_simplify_poc
branch
from
eb0eae1
to
1c3c141
Compare
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1983 1956 -27
=========================================
- Hits 1983 1956 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
approved these changes
May 21, 2022
axic
reviewed
May 21, 2022
| @@ -1785,7 +1775,7 @@ inline void udivrem_knuth( | |||
| } // namespace internal | |||
|
|
|||
| template <unsigned M, unsigned N> | |||
| div_result<uint<M>, uint<N>> udivrem(const uint<M>& u, const uint<N>& v) noexcept | |||
| constexpr div_result<uint<M>, uint<N>> udivrem(const uint<M>& u, const uint<N>& v) noexcept | |||
There was a problem hiding this comment.
Was this constexpr just missed?
There was a problem hiding this comment.
Yes. Maybe we never used it in constexpr context but now compiler is not happy as we removed one level of templates and maybe it is obviously wrong now.
|
No performance changes. In the end we define the same functions just is some other location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.