Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change shift amount param from unsigned to uint64_t #202

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Conversation

chfast
Copy link
Owner

@chfast chfast commented Mar 4, 2021

This simplifies reduction from any intx::uint to the shift amount param
because we can just use the lowest word for this.

@codecov-io
Copy link

codecov-io commented Mar 4, 2021

Codecov Report

Merging #202 (fbbf837) into master (6c39eb7) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   99.88%   99.65%   -0.24%     
==========================================
  Files           9        9              
  Lines        2567     2579      +12     
==========================================
+ Hits         2564     2570       +6     
- Misses          3        9       +6     
Flag Coverage Δ
32bit 99.87% <100.00%> (-0.13%) ⬇️
clang 99.09% <100.00%> (-0.26%) ⬇️
gcc 99.87% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/intx/int128.hpp 99.46% <100.00%> (ø)
include/intx/intx.hpp 99.19% <100.00%> (-0.81%) ⬇️
test/unittests/test_intx.cpp 100.00% <100.00%> (ø)

This simplifies reduction from any intx::uint to the shift amount param
because we can just use the lowest word for this.
@chfast chfast merged commit e65727d into master Mar 4, 2021
@chfast chfast deleted the shift_arg branch March 4, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants