-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance bottleneck #5
Comments
That's a good point. This change will definitely reduce the time for searching the array for the specified node. Thank you for the finding. |
Thank you. |
Just published 0.11.1 to address the performance issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Thank you for the awesome infinit-tree library. When I try to load 80k+ nodes under a single node, this line incredibly slows down the loading :
flattree/src/flatten.js
Line 123 in 6b0f516
I think you can change this line with a less expensive check :
if(index === current.children.length-1)
I gained 1.4 seconds with this. Can you confirm that I didn't break something ? It seems to me that the original check does a long roundtrip to just do that simple check.
Thank you,
Yassine
The text was updated successfully, but these errors were encountered: