Extend Specification for CMake Commands #54
Conversation
| @@ -511,11 +525,26 @@ def get_fn_spec(): | |||
| "RUN_OUTPUT_VARIABLE": ZERO_OR_MORE | |||
| }) | |||
|
|
|||
| fn_spec.add( | |||
There was a problem hiding this comment.
Hm... I wonder is it best to include functions that aren't builtin but provided by standard findscripts or listfiles? Lemme think about that...
| fn_spec.add( | ||
| "if", flags=[], kwargs={ | ||
| "NOT": ONE_OR_MORE, | ||
| "AND": ONE_OR_MORE, | ||
| "OR": ONE_OR_MORE | ||
| "OR": ONE_OR_MORE, |
There was a problem hiding this comment.
I know its odd but looking at a few instances of complex boolean statements in my own listfiles, the formatting generally looks better if most of these act as "flags" even though they are really keywords. This is what I do in parser.py currently for conditional groups. It makes me think the formatting rules should be made more robust or configurable, but for now I'm going to do the same for the if spec.
|
I'm going to re-open this as v0.4.1 doesn't add Oh nevermind, original branch removed. Going to make an issue so I don't forget. |
This PR extends the specification for some builtin CMake commands. It should improve the formatting for the commands
ifinstall,export, andwrite_basic_package_version_filea little bit.
If I should change anything in this pull request, then please just comment below. Thank you.