Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranges / integrals, default behaviour and value #3056

Open
jliermann opened this issue May 22, 2024 · 5 comments · May be fixed by #3084
Open

Ranges / integrals, default behaviour and value #3056

jliermann opened this issue May 22, 2024 · 5 comments · May be fixed by #3084
Assignees
Labels
enhancement New feature or request

Comments

@jliermann
Copy link
Collaborator

The current behaviour of the range / integral tool with a sum value and relative integration is somewhat confusing to synthetic chemists. I suggest that the first integral placed should always have an absolute value of 1.

@evaziegler

@lpatiny lpatiny added the enhancement New feature or request label May 27, 2024
@lpatiny
Copy link
Member

lpatiny commented May 27, 2024

First step would be to add the 'link' toggle from integrals and ranges saved in the workspace

image

Second step: if the link is unselected and we add a first integral or range it's value is set to '1'.

@hamed-musallam
Copy link
Member

@lpatiny

Toggle the integrals and ranges are specific to each spectrum, which is why they are included in the view object rather than in the workspace. The workspace is intended for general settings.

@hamed-musallam hamed-musallam linked a pull request Jun 7, 2024 that will close this issue
@lpatiny
Copy link
Member

lpatiny commented Jun 7, 2024

Thanks Hamed. I think this can be changed without any migration script. Those settings can be in the workspace and not related to a spectrum. They can be specific for a nucleus (1H, 13C, 19F) and saved in the workspace.

@hamed-musallam
Copy link
Member

Sorry, that was a mistake on my part. These options belong to the ranges and integrals settings:

{
  options: { isSumConstant: boolean },
  values: []
}

@hamed-musallam
Copy link
Member

hamed-musallam commented Jun 7, 2024

@lpatiny
we rely on this option to adjust the relative value. If we move this option to the workspace, we still need to keep it in the data because the ranges and integrals reducer actions check this option whenever we modify ranges or integrals. Otherwise, we would need to pass this option in all actions related to ranges and integrals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants