Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to nmredata extension n multiple spectrum sources #44

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Sep 18, 2023

sometimes I found there are two Spectrum_Location tag

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 80.64% and project coverage change: +0.22% 🎉

Comparison is base (91f0dd1) 54.75% compared to head (11b9d97) 54.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   54.75%   54.98%   +0.22%     
==========================================
  Files          24       24              
  Lines         747      753       +6     
  Branches      224      228       +4     
==========================================
+ Hits          409      414       +5     
  Misses        274      274              
- Partials       64       65       +1     
Files Changed Coverage Δ
src/converter/util/toJSON/getJcamp.js 42.85% <0.00%> (ø)
src/converter/util/toJSON/getBrukerFiles.js 80.00% <78.26%> (-4.22%) ⬇️
src/converter/nmredataToJSON.js 91.42% <100.00%> (+2.53%) ⬆️
src/util/getSDF.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobo322 jobo322 linked an issue Sep 18, 2023 that may be closed by this pull request
@jobo322 jobo322 changed the title chore: file is an array source of spectrum file is an array Sep 19, 2023
@jobo322 jobo322 changed the title source of spectrum file is an array support to nmredata extension n multiple spectrum sources Sep 21, 2023
@jobo322 jobo322 merged commit bf6f2d6 into main Sep 21, 2023
9 checks passed
@jobo322 jobo322 deleted the nmredata_multi_Spectrum_locations branch September 21, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for remote spectra data
1 participant