Add openvms detection #159

briandoodyie · 2016-11-03T14:31:41Z

This has been tested with OpenVMS 8.3.

Added openvms detection
Removed the hardcoding of ssh_connection setting platform to unix.
In os_common.rb we can now more accurately determine the platform by using uname_s method. Openvms does not have understand uname_s and doesnt generate an error detectable by the command object. However you can check the message coming from that for the generic openvms error.

…g hardcoded to unix

chris-rock · 2016-11-03T14:33:03Z

lib/train/extras/os_common.rb

@@ -96,6 +98,8 @@ def detect_family
      # TODO: extend base implementation for detecting the family type
      # to Windows and others
      case uname_s
+      when /unrecognized command verb/


not sure if we can expect that every system that has not uname_s is openvms

maybe we just don't set any family then

problem is that if we omit this part, it matches

when /./
@platform[:family] = 'unix'

Its a pain because the uname_s command doesnt returns an error that can be detected by the command object (old os) but a message that says : %DCL-W-IVVERB, unrecognized command verb - check validity and spelling

I think we should create a method for detecting non-uname operating systems. Is there a reliable command that only works on openvms to detect the family?

Okay, lets use this for now until we find any other non-uname operating system

chris-rock · 2016-11-03T14:50:20Z

lib/train/extras/os_common.rb

@@ -124,6 +129,7 @@ def detect_family_type # rubocop:disable Metrics/CyclomaticComplexity, Metrics/P
      # unix based systems combine the above
      return true if pf == 'unix' and detect_darwin
      return true if pf == 'unix' and detect_esx
+      #This is assuming that pf is set to unix, this should be if pf == 'linux'


I think we can argue that arista should be in detect_linux

@backend.run_command('show system/noprocess') will always return OpenVMS Vxx e.g. "OpenVMS V8.2 on node VS3B2 3-NOV-2016 21:41:10.97 Uptime 171 04:49:02

"

chris-rock · 2016-11-03T14:51:43Z

lib/train/extras/os_common.rb

@@ -96,6 +98,8 @@ def detect_family
      # TODO: extend base implementation for detecting the family type
      # to Windows and others
      case uname_s
+      when /unrecognized command verb/


I think we should create a method for detecting non-uname operating systems. Is there a reliable command that only works on openvms to detect the family?

chris-rock · 2016-11-03T21:06:29Z

Could you please sign off your commits? Are you resolving the linting issues?

Signed-off-by: Brian Doody <[email protected]>

…ie/train into add_openvms_detection Signed-off-by: Brian Doody <[email protected]>

briandoodyie · 2016-11-04T12:14:07Z

Looking at the lint testing part now

Signed-off-by: Brian Doody <[email protected]>

a Signed-off-by: Brian Doody <[email protected]>

…ie/train into add_openvms_detection Signed-off-by: Brian Doody <[email protected]> Conflicts: lib/train/extras/os_detect_openvms.rb

briandoodyie · 2016-11-07T09:49:34Z

@chris-rock not sure on this final error. All the lint testing should pass now.

chris-rock · 2016-11-08T03:21:03Z

awesome @briandoodyie I think we are getting very close...

chris-rock · 2016-11-08T03:15:27Z

lib/train/extras/os_common.rb

@@ -124,6 +129,7 @@ def detect_family_type # rubocop:disable Metrics/CyclomaticComplexity, Metrics/P
      # unix based systems combine the above
      return true if pf == 'unix' and detect_darwin
      return true if pf == 'unix' and detect_esx
+      # This is assuming that pf is set to unix, this should be if pf == 'linux'


we should remove that command, since from trains perspective linux is a subset of a unix-like operating system.

chris-rock · 2016-11-08T03:18:09Z

lib/train/extras/os_common.rb

@@ -96,6 +98,8 @@ def detect_family
      # TODO: extend base implementation for detecting the family type
      # to Windows and others
      case uname_s
+      when /unrecognized command verb/
+        @platform[:family] = 'openvms'


Since we cannot expect that every non-uname system is openvms I would prefer to set it to nil here?

chris-rock · 2016-11-08T03:20:01Z

lib/train/transports/ssh_connection.rb

@@ -230,7 +230,7 @@ def to_s

    class OS < OSCommon
      def initialize(backend)
-        super(backend, { family: 'unix' })


I just thinking if it is not easier to count openvms as a unix-like system as well? Not sure about that. This would allow us to just use

return true if pf =='unix' && detect_openvms

This was the original code and the problem there is that

chris-rock · 2016-11-09T14:27:21Z

@briandoodyie Anything I can help with?

briandoodyie · 2016-11-10T10:42:12Z

Hmmm the ssh access will work and was the original change that was made. It made everything a lot simpler but doesnt windows now also support ssh. Might be assumption that just doesnt work now. thoughts? @chris-rock

chris-rock · 2016-11-11T18:48:56Z

@briandoodyie I wanna clean this up as well, I just want to do this in two steps. I apologize for the confusion

chris-rock · 2016-11-11T19:19:52Z

@briandoodyie I go with the current PR. Thanks @briandoodyie for putting all the effort into that

briandoodyie added 3 commits November 3, 2016 14:23

Adding openvms detection and fixing platform detection which was bein…

c14774e

…g hardcoded to unix

Removing hardcoded unix platform

ea9da75

OpenVMS Detection

34df1f8

chris-rock reviewed Nov 3, 2016

View reviewed changes

briandoodyie added 2 commits November 4, 2016 11:19

OpenVMS Detection

df89031

Signed-off-by: Brian Doody <[email protected]>

Merge branch 'add_openvms_detection' of https://github.com/briandoody…

4c1071e

…ie/train into add_openvms_detection Signed-off-by: Brian Doody <[email protected]>

briandoodyie force-pushed the add_openvms_detection branch from e5e1178 to 4c1071e Compare November 4, 2016 11:28

briandoodyie added 3 commits November 4, 2016 12:18

Lint test fixes for changed code

a4391c2

Signed-off-by: Brian Doody <[email protected]>

Lint test fixes for changed code

a5a8893

a Signed-off-by: Brian Doody <[email protected]>

Merge branch 'add_openvms_detection' of https://github.com/briandoody…

9599fd3

…ie/train into add_openvms_detection Signed-off-by: Brian Doody <[email protected]> Conflicts: lib/train/extras/os_detect_openvms.rb

chris-rock reviewed Nov 8, 2016

View reviewed changes

chris-rock merged commit 0404986 into inspec:master Nov 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add openvms detection #159

Add openvms detection #159

briandoodyie commented Nov 3, 2016

chris-rock Nov 3, 2016

chris-rock Nov 3, 2016

briandoodyie Nov 3, 2016

briandoodyie Nov 3, 2016

chris-rock Nov 3, 2016

chris-rock Nov 3, 2016

chris-rock Nov 3, 2016

briandoodyie Nov 3, 2016

chris-rock Nov 3, 2016

chris-rock commented Nov 3, 2016 •

edited

Loading

briandoodyie commented Nov 4, 2016

briandoodyie commented Nov 7, 2016

chris-rock commented Nov 8, 2016

chris-rock Nov 8, 2016

chris-rock Nov 8, 2016

chris-rock Nov 8, 2016

briandoodyie Nov 10, 2016

chris-rock commented Nov 9, 2016

briandoodyie commented Nov 10, 2016

chris-rock commented Nov 11, 2016 •

edited

Loading

chris-rock commented Nov 11, 2016

Add openvms detection #159

Add openvms detection #159

Conversation

briandoodyie commented Nov 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chris-rock commented Nov 3, 2016 • edited Loading

briandoodyie commented Nov 4, 2016

briandoodyie commented Nov 7, 2016

chris-rock commented Nov 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chris-rock commented Nov 9, 2016

briandoodyie commented Nov 10, 2016

chris-rock commented Nov 11, 2016 • edited Loading

chris-rock commented Nov 11, 2016

chris-rock commented Nov 3, 2016 •

edited

Loading

chris-rock commented Nov 11, 2016 •

edited

Loading