-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert wmic
architecture to a normal standard
#151
Convert wmic
architecture to a normal standard
#151
Conversation
@@ -7,6 +7,7 @@ | |||
# OHAI https://github.com/chef/ohai | |||
# by Adam Jacob, Chef Software Inc | |||
# | |||
require 'pry' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove pry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 Done!
Thanks @jerryaldrichiii this is a really good improvement. |
we missed to update the functional test for appveyor. please update the
See https://github.com/chef/train/blob/master/test/windows/local_test.rb#L22-L28 and https://github.com/chef/train/blob/master/test/windows/winrm_test.rb#L28-L34 |
Yup! I missed that too! Tests have been updated. |
fixes inspec/inspec#1100 |
This modifies the value of `@platform[:arch]` on Windows to resemble what `uname` would return on Unix/Linux.
Thanks @jerryaldrichiii the timeout error with docker is not related to this PR |
Windows
wmic os get
outputs values that are not expected for CPU architecture.For example, instead of
x86_64
ori386
it returns64-bit
and32-bit
This uses the output of
wmic cpu get architecture
and converts it to something that is expected from commands likeuname
orarch
.This is intended to resolve the InSpec issue brought up by @seththoenen here and is an alternative to my InSpec PR here.