Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve NoMethodError for fog providers that do not provide the 'addresses' method to the 'server' object #93

Merged
merged 3 commits into from
Aug 12, 2015

Conversation

SIGUSR2
Copy link
Contributor

@SIGUSR2 SIGUSR2 commented Mar 30, 2015

@jkeiser
Copy link
Contributor

jkeiser commented Apr 27, 2015

Thanks for getting this! The solution here is for this is to override the method in https://github.com/chef/chef-provisioning-fog/blob/master/lib/chef/provisioning/fog_driver/providers/joyent.rb:

def find_floating_ips(server)
  []
end

Terribly sorry for the late review, post-ChefConf madness destroyed my availability for a bit.

@SIGUSR2
Copy link
Contributor Author

SIGUSR2 commented Apr 28, 2015

@jkeiser No problem. I made the change(s) in my repo, guess it may be merged now.

@hulu1522
Copy link
Contributor

Associated with issue #118

@randomcamel
Copy link
Contributor

@SIGUSR2 Seems odd that this works when the signature doesn't match the superclass method:

def find_floating_ips(server, action_handler)

But if it works, it works.

@SIGUSR2
Copy link
Contributor Author

SIGUSR2 commented Aug 12, 2015

@randomcamel It probably does not. This PR was made when the method had only one argument. Fix added. Hope it will be merged before the method ends up having 3 or more arguments.

@randomcamel
Copy link
Contributor

@SIGUSR2 Touché.

randomcamel added a commit that referenced this pull request Aug 12, 2015
Solve NoMethodError for fog providers that do not provide the 'addresses' method to the 'server' object
@randomcamel randomcamel merged commit cabb791 into chef-boneyard:master Aug 12, 2015
@SIGUSR2
Copy link
Contributor Author

SIGUSR2 commented Aug 12, 2015

@randomcamel Thanks :)

@tas50 tas50 added Type: Bug Doesn't work as expected. and removed Bug labels Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Doesn't work as expected.
Development

Successfully merging this pull request may close these issues.

7 participants