-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve NoMethodError for fog providers that do not provide the 'addresses' method to the 'server' object #93
Conversation
… an 'addresses' method on their servers (see https://apidocs.joyent.com/cloudapi/#CreateMachine)
Thanks for getting this! The solution here is for this is to override the method in https://github.com/chef/chef-provisioning-fog/blob/master/lib/chef/provisioning/fog_driver/providers/joyent.rb: def find_floating_ips(server)
[]
end Terribly sorry for the late review, post-ChefConf madness destroyed my availability for a bit. |
@jkeiser No problem. I made the change(s) in my repo, guess it may be merged now. |
Associated with issue #118 |
@SIGUSR2 Seems odd that this works when the signature doesn't match the superclass method:
But if it works, it works. |
@randomcamel It probably does not. This PR was made when the method had only one argument. Fix added. Hope it will be merged before the method ends up having 3 or more arguments. |
@SIGUSR2 Touché. |
Solve NoMethodError for fog providers that do not provide the 'addresses' method to the 'server' object
@randomcamel Thanks :) |
see https://apidocs.joyent.com/cloudapi/#CreateMachine