Fix bug where ip address is not returned from guest tools #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Barker <[email protected]>
josh-barker
commented
Jun 4, 2018
| @@ -17,12 +17,6 @@ class VmHelper | |||
| Timeout::Error, IPAddr::AddressFamilyError | |||
| ].freeze | |||
|
|
|||
| # If the IP is true | |||
There was a problem hiding this comment.
Removed code as there was only 1 reference to it, in the ip_to_bootstrap method
josh-barker
commented
Jun 4, 2018
| else | ||
| ## Check if true available | ||
| vm_ip = bootstrap_options[:customization_spec][:ipsettings][:ip] unless vm_helper.ip? | ||
| nb_attempts = 0 | ||
| until @vm_helper.open_port?(vm_ip, @vm_helper.port, 1) || (nb_attempts > (bootstrap_options[:ready_timeout] || 90)) |
There was a problem hiding this comment.
Removed port checking as we're already checking that at the end of the method.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug where the ip address is not returned from the guest tools properly.
This causes the connectivity test to fail, because its trying to connect to ip address
nil.Check List