Add dropdown by state to filter flags #433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the home page we currently have a first row to add new flags and a second row to search for flags. We have modified the second row in order to show a dropdown list in which we can see the values [
All the flags
,Enabled flags
,Disabled flags
] being the valueAll the flags
the one selected by default.As the current API supports the boolean parameter
enabled
to filter flags by enabled and disabled, we only needed to change the GUI to add the filter.Motivation and Context
The number of flags is growing and as this is a service shared by all of our customers, it is expected it will continue growing in the future. To do it easier to work with Flagr we want to provide a way of filtering flags by status (enabled / disabled).
How Has This Been Tested?
Flag Y1
,Flag Y2
,Flag Z1
andFlag Z2
.Flag Y1
andFlag Z1
.Enabled flags
and onlyFlag Y1
andFlag Z1
were shown (as expected).Disabled flags
and onlyFlag Y2
andFlag Z2
were shown (as expected).All the flags
and the four flags were shown (as expected).Flag Z1
andFlag Z2
were shown (as expected).Enabled flags
and onlyFlag Z1
was shown (as expected).Disabled flags
and onlyFlag Z2
was shown (as expected).Flag Z1
andFlag Z2
were shown (as expected).Types of changes
Checklist: