Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the style for deleted flags table #393

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented Sep 4, 2020

Description

  • Tweak a little bit of the style of the deleted flags table.
  • Add a confirmation message for "restore" button
  • Change the font family to match the "flag note"'s github style

image
image

Motivation and Context

How Has This Been Tested?

Tested locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie zhouzhuojie force-pushed the zz/style-tweaks-for-deleted-flags branch from 8727d11 to 3e83a4b Compare September 4, 2020 22:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          27       27           
  Lines        1755     1755           
=======================================
  Hits         1457     1457           
  Misses        214      214           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11146d8...2140d41. Read the comment docs.

@zhouzhuojie zhouzhuojie force-pushed the zz/style-tweaks-for-deleted-flags branch from 3e83a4b to 32c05a8 Compare September 4, 2020 23:07
@zhouzhuojie zhouzhuojie force-pushed the zz/style-tweaks-for-deleted-flags branch from 32c05a8 to 2140d41 Compare September 4, 2020 23:09
@zhouzhuojie zhouzhuojie merged commit 0c7ca05 into master Sep 4, 2020
@zhouzhuojie zhouzhuojie deleted the zz/style-tweaks-for-deleted-flags branch September 4, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants