Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json attachment validation and minimist dependency #327

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented Mar 17, 2020

Description

Motivation and Context

How Has This Been Tested?

UI tests:

Normal Case:
image

Invalid Case:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie zhouzhuojie force-pushed the zz/fix-json-attachment branch from 219f852 to 5335ed6 Compare March 17, 2020 01:29
@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #327 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files          26       26           
  Lines        1537     1537           
=======================================
  Hits         1259     1259           
  Misses        209      209           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10c6a9...4cde936. Read the comment docs.

@zhouzhuojie zhouzhuojie force-pushed the zz/fix-json-attachment branch from 5335ed6 to e89799e Compare March 17, 2020 01:32
@zhouzhuojie zhouzhuojie changed the title Fix json attachment validation Fix json attachment validation and minimist dependency Mar 17, 2020
@zhouzhuojie zhouzhuojie merged commit b62e1b4 into master Mar 17, 2020
@zhouzhuojie zhouzhuojie deleted the zz/fix-json-attachment branch March 17, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When attempting to save an invalid JSON blob for a variant attachment, flagr reports success
2 participants