Add ability to enable newrelic's distributed tracing

[jaysonsantos]

Description

Add ability to enable newrelic's distributed tracing

Motivation and Context

This is a feature within newrelic's agent that is by default off and the only way to enable on go agent is by setting in the config, the other method with the env NEW_RELIC_DISTRIBUTED_TRACING_ENABLED=true won't work as the go agent doesn't read env variables.

How Has This Been Tested?

I've deployed the docker image with the changes a server and checked newrelic's distributed tracing and they showed up.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation. (The docs point to the struct code)
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov-io]

Codecov Report

Merging #305 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   81.83%   81.85%   +0.02%     
==========================================
  Files          26       26              
  Lines        1536     1538       +2     
==========================================
+ Hits         1257     1259       +2     
  Misses        210      210              
  Partials       69       69

Impacted Files	Coverage Δ
pkg/config/config.go	79.71% <100%> (+0.6%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca88144...bdd533c. Read the comment docs.

[zhouzhuojie]

can you link some newrelic documentation for this? Thanks

[jaysonsantos]

Hey there, I only spotted it when I deployed it to a testing server but they also mention it here [1] [1] https://github.com/newrelic/go-agent/blob/master/config.go#L201 Cheers, Jayson Em seg., 2 de dez. de 2019 às 21:55, Zhuojie Zhou <[email protected]> escreveu:

…

***@***.**** commented on this pull request. ------------------------------ In pkg/config/config.go <#305 (comment)>: > @@ -93,6 +93,9 @@ func setupNewrelic() { if Config.NewRelicEnabled { nCfg := newrelic.NewConfig(Config.NewRelicAppName, Config.NewRelicKey) nCfg.Enabled = true + // These two cannot be enabled at the same time and cross application is enabled by default can you link some newrelic documentation for this? Thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#305>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMSNRHQL6FGKGPQGTHGMTQWVY3BANCNFSM4JOEIJUQ> .