-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting created_by/updated_by via header #300
Conversation
We had this changes in place for sometime now and they work just fine. We set up flagr UI behind an |
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 81.8% 81.83% +0.03%
==========================================
Files 26 26
Lines 1533 1536 +3
==========================================
+ Hits 1254 1257 +3
Misses 210 210
Partials 69 69
Continue to review full report at Codecov.
|
@zhouzhuojie I've applied the feedback ready to review |
It seems unit test failed due to other reason https://circleci.com/gh/checkr/flagr/986?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left one comment
Co-Authored-By: Zhuojie Zhou <[email protected]>
Thanks, I've applied the suggetion |
Thanks! |
Description
Provide two new configuration settings:
AuthProxyEnabled
to enable retrieving a header to be used on created_by/updated_byAuthProxyHeader
header to use defaults toX-Email
Motivation and Context
Required at #297
How Has This Been Tested?
Added unit test to ensure this works as expected
Types of changes
Checklist: