Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Put EvalFlag public #299

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

tkanos
Copy link

@tkanos tkanos commented Oct 22, 2019

In order to use flagr as a go package, EvalFlag should be public.

ref #298

Description

I put evalFlag public

Motivation and Context

As I work with flagr as a go package, to implement my own evaluator base on flagr solution. EvalFlag was the only function that needed to be public and was not. (see #298 )

How Has This Been Tested?

The test have been updated, but they don;t need to be changed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated tests to cover my changes.
  • All new and existing tests passed.

In order to use flagr as a go package, EvalFlag should be public.

ref openflagr#298
@codecov-io
Copy link

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #299   +/-   ##
======================================
  Coverage    81.8%   81.8%           
======================================
  Files          26      26           
  Lines        1533    1533           
======================================
  Hits         1254    1254           
  Misses        210     210           
  Partials       69      69
Impacted Files Coverage Δ
pkg/handler/eval.go 77.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9c515...af93b24. Read the comment docs.

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouzhuojie zhouzhuojie merged commit 2668d5c into openflagr:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants