Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Postgres connection string example #296

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

iJackUA
Copy link
Contributor

@iJackUA iJackUA commented Oct 11, 2019

Description

The provided example string was not working for me with Postgres.
I propose one that works.

Motivation and Context

It helps to start running Flagr with Postgres quickly

How Has This Been Tested?

Tested manually on local machine in docker compose env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #296   +/-   ##
======================================
  Coverage    81.8%   81.8%           
======================================
  Files          26      26           
  Lines        1533    1533           
======================================
  Hits         1254    1254           
  Misses        210     210           
  Partials       69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f106032...44c537f. Read the comment docs.

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think I also like the url style for consistency.

Both of the styles should work, and they are documented here: https://godoc.org/github.com/lib/pq

@zhouzhuojie zhouzhuojie merged commit ba9c515 into openflagr:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants