-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] allow creating a flag with a specific ID #286
Comments
I think changing the |
I think we already have |
@zhouzhuojie Sure. Following your comment, can we close this issue? |
Closing this works for me! After digging into the tools available more, I can use flagKey or entityContext to get what I need done just fine. |
Request adding the ability to create a flag with a specific ID, and/or modify the ID after the fact. When developing against Flagr, I may want to test a flag in multiple environments and we sometimes hardcode the flag ID to check. I would want to be able to set up a local flagr to use the same IDs as a production environment. Possibly this is somewhat low priority because you can export / import as a workaround.
Expected Behavior
Add an 'id' field to relevant CRUD methods for
Flag
in the API, and make it editable in the UI.Current Behavior
The id is set automatically when creating a flag, and can't be changed.
Possible Solution
Might need to make the flag ID that is visible in the API a different field than the actual database ID.
Steps to Reproduce (for bugs)
Create a flag, observe the ID that is used in the evaluation API can't be edited.
Context
I start a local instance of the flagr docker to test some code that uses flagr's evaluation API. To do this I need to temporarily edit the flag ID used by my code.
The text was updated successfully, but these errors were encountered: